Browse Source

refactor(sdk): 明确 AdapterConfig 不是配置项

SDK 的初衷是不读任何配置、不碰任何存储。原 AdapterConfig 带 endpointBaseUrl +
sandbox 两个字段,容易被误解为可配置端点;sandbox 更是与 ChannelAccount.sandbox
重复且从未被工厂使用。

- AdapterConfig 收敛为单一字段 endpointBaseUrl,仅用于测试/联调覆盖目标地址
- 新增 AdapterConfig.NONE 常量,替换 ChannelSdk 里内联的 new AdapterConfig(null, false)
- LingxingConstants 补注释:端点与路径属于协议,必须写在代码里

Co-Authored-By: Claude <noreply@anthropic.com>
feature/supplier-lingxing
chenchuchuan 3 weeks ago
parent
commit
64209629ff
  1. 21
      core/src/main/java/common/ecommerce/sdk/AdapterFactory.java
  2. 4
      core/src/main/java/common/ecommerce/sdk/ChannelSdk.java
  3. 9
      lingxing/src/main/java/common/ecommerce/lingxing/LingxingConstants.java

21
core/src/main/java/common/ecommerce/sdk/AdapterFactory.java

@ -20,24 +20,29 @@ public interface AdapterFactory {
PlatformAdapter create(AdapterConfig config); PlatformAdapter create(AdapterConfig config);
/** 适配器实例化所需的最小配置;凭证与账户信息在调用时经 ChannelContext 传入。 */ /**
* 适配器实例化参数。
*
* <p><b>不是配置项</b>:SDK 不读配置文件、不查配置中心。端点、路径、限流等协议细节
* 全部内置在适配器代码里;这里只承载「测试/联调时替换目标地址」这一种由调用方显式传入的
* 参数。凭证与账户信息(含沙箱标记)属于账户数据,调用时经
* {@link common.ecommerce.sdk.ChannelContext} 传入。</p>
*/
final class AdapterConfig { final class AdapterConfig {
/** 不覆盖任何默认值,使用适配器内置端点。 */
public static final AdapterConfig NONE = new AdapterConfig(null);
private final String endpointBaseUrl; private final String endpointBaseUrl;
private final boolean sandbox;
public AdapterConfig(String endpointBaseUrl, boolean sandbox) { public AdapterConfig(String endpointBaseUrl) {
this.endpointBaseUrl = endpointBaseUrl; this.endpointBaseUrl = endpointBaseUrl;
this.sandbox = sandbox;
} }
/** 仅用于测试/联调;为 null 表示使用适配器内置端点。 */
public String endpointBaseUrl() { public String endpointBaseUrl() {
return endpointBaseUrl; return endpointBaseUrl;
} }
public boolean sandbox() {
return sandbox;
}
} }
/** 兜底:由平台推导默认 adapterId,便于日志定位。 */ /** 兜底:由平台推导默认 adapterId,便于日志定位。 */

4
core/src/main/java/common/ecommerce/sdk/ChannelSdk.java

@ -10,6 +10,7 @@ import common.ecommerce.idempotency.IdempotencyGuard;
import common.ecommerce.model.account.AccountKey; import common.ecommerce.model.account.AccountKey;
import common.ecommerce.model.account.ChannelAccount; import common.ecommerce.model.account.ChannelAccount;
import common.ecommerce.spi.ChannelAccountRepository; import common.ecommerce.spi.ChannelAccountRepository;
import common.ecommerce.sdk.AdapterFactory.AdapterConfig;
import common.ecommerce.spi.IdempotencyStore; import common.ecommerce.spi.IdempotencyStore;
import java.time.Clock; import java.time.Clock;
@ -186,8 +187,9 @@ public final class ChannelSdk implements ProviderResolver {
if (adapters.isEmpty() && factories.isEmpty()) { if (adapters.isEmpty() && factories.isEmpty()) {
throw new IllegalStateException("ChannelSdk requires at least one adapter or adapter factory"); throw new IllegalStateException("ChannelSdk requires at least one adapter or adapter factory");
} }
// 端点内置于适配器代码,SDK 不读配置;AdapterConfig 只承载端口覆盖等测试用参数
for (AdapterFactory factory : factories) { for (AdapterFactory factory : factories) {
register(factory.create(new AdapterFactory.AdapterConfig(null, false))); register(factory.create(AdapterConfig.NONE));
} }
return new ChannelSdk(this); return new ChannelSdk(this);
} }

9
lingxing/src/main/java/common/ecommerce/lingxing/LingxingConstants.java

@ -1,10 +1,15 @@
package common.ecommerce.lingxing; package common.ecommerce.lingxing;
import common.ecommerce.model.Platform; import common.ecommerce.model.Platform;
/** 领星常量与 platform_code 映射。 */ /**
* 领星协议常量与 platform_code 映射。
*
* <p>端点与路径是<b>协议的一部分</b>,必须写在代码里,不做成配置表:
* 配置化会让线上与测试跑不同协议,出错时无法从代码复现。</p>
*/
public final class LingxingConstants { public final class LingxingConstants {
/** 生产环境基址。 */ /** 生产环境基址;仅在测试/联调时由 AdapterConfig 覆盖。 */
public static final String DEFAULT_BASE_URL = "https://openapi.lingxing.com"; public static final String DEFAULT_BASE_URL = "https://openapi.lingxing.com";
public static final String ADAPTER_ID = "lingxing"; public static final String ADAPTER_ID = "lingxing";

Loading…
Cancel
Save