From 8560c2ea475981d0c13947ef739e4b9ad00f548a Mon Sep 17 00:00:00 2001 From: chenchuchuan <13554600537@163.com> Date: Fri, 30 Oct 2026 15:12:31 +0800 Subject: [PATCH] =?UTF-8?q?build(lingxing):=20DTO=20=E4=BD=BF=E7=94=A8=20L?= =?UTF-8?q?ombok=20=E7=94=9F=E6=88=90=E8=AE=BF=E9=97=AE=E5=99=A8?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 两个领星 DTO 是纯数据容器,访问器占 47 行样板代码。改用 @Getter/@Setter 后: - LingxingOrderDto 196 → 82 行 - LingxingOrderItemDto 88 → 40 行 范围限定在 lingxing/dto:core 的领域模型是不可变 + Builder,不使用 Lombok。 依赖 scope=provided,不进宿主运行时。 Co-Authored-By: Claude --- GUIDE.md | 8 +- README.md | 6 +- lingxing/pom.xml | 5 + .../ecommerce/lingxing/dto/LingxingOrderDto.java | 126 +-------------------- .../lingxing/dto/LingxingOrderItemDto.java | 68 ++--------- pom.xml | 7 ++ 6 files changed, 39 insertions(+), 181 deletions(-) diff --git a/GUIDE.md b/GUIDE.md index f72781b..a8879ec 100644 --- a/GUIDE.md +++ b/GUIDE.md @@ -438,6 +438,8 @@ public final class AcmeConstants { ### 第 3 步:DTO —— 平台字段名的唯一落点 ```java +@Getter +@Setter @JsonIgnoreProperties(ignoreUnknown = true) public final class AcmeOrderDto { @@ -448,13 +450,15 @@ public final class AcmeOrderDto { @JsonProperty("currency") private String currency; @JsonProperty("created_at") private Long createdAt; // 注意秒/毫秒 @JsonProperty("lines") private List lines; - - // getters / setters } ``` **平台字段名只允许出现在 DTO 和 Mapper 里。** +**DTO 用 Lombok,领域模型不用。** DTO 是纯数据容器,没有不变量要保护,`@Getter`/`@Setter` +省掉全部样板;`core` 的模型是不可变 + Builder,本来就没有 setter,且 `core` 要尽量少依赖 +编译期工具。Lombok 声明为 `scope=provided`,不进宿主运行时。 + ### 第 4 步:Mapper —— DTO → 统一模型 ```java diff --git a/README.md b/README.md index 922f220..b59ab52 100644 --- a/README.md +++ b/README.md @@ -21,7 +21,11 @@ | `common-ecommerce-core` | 领域模型、能力接口、门面、管道、SPI。**零第三方运行时依赖** | | `common-ecommerce-http` | HTTP 传输、签名、令牌管理、JSON 编解码 | | `common-ecommerce-testkit` | InMemory SPI、FakeTransport、夹具加载、断言工具 | -| `common-ecommerce-lingxing` | 领星聚合适配器(多子平台) | +| `common-ecommerce-lingxing` | 领星聚合适配器(多子平台)。DTO 用 Lombok 生成访问器 | + +**Lombok 使用范围**:仅 `lingxing` 模块的 `dto/*`,`scope=provided`,不进宿主运行时。 +`core` 的领域模型是**不可变 + Builder**,不使用 Lombok——省下的行数有限, +而 `core` 要尽量少依赖编译期工具。 ## 构建 diff --git a/lingxing/pom.xml b/lingxing/pom.xml index 6d9c67e..6e7de4a 100644 --- a/lingxing/pom.xml +++ b/lingxing/pom.xml @@ -30,6 +30,11 @@ org.slf4j slf4j-api + + org.projectlombok + lombok + provided + ecommerce diff --git a/lingxing/src/main/java/common/ecommerce/lingxing/dto/LingxingOrderDto.java b/lingxing/src/main/java/common/ecommerce/lingxing/dto/LingxingOrderDto.java index 363187d..01e00a9 100644 --- a/lingxing/src/main/java/common/ecommerce/lingxing/dto/LingxingOrderDto.java +++ b/lingxing/src/main/java/common/ecommerce/lingxing/dto/LingxingOrderDto.java @@ -2,6 +2,8 @@ package common.ecommerce.lingxing.dto; import com.fasterxml.jackson.annotation.JsonIgnoreProperties; import com.fasterxml.jackson.annotation.JsonProperty; +import lombok.Getter; +import lombok.Setter; import java.util.ArrayList; import java.util.List; @@ -11,7 +13,11 @@ import java.util.List; * *

待核对:字段名依据领星 OpenAPI 文档摘录,联调时以官方最新文档 * 与真实响应为准;调整集中在本 DTO 与 {@code LingxingOrderMapper}。

+ * + *

纯数据容器,使用 Lombok 生成访问器;不承载任何业务不变量。

*/ +@Getter +@Setter @JsonIgnoreProperties(ignoreUnknown = true) public class LingxingOrderDto { @@ -73,124 +79,4 @@ public class LingxingOrderDto { @JsonProperty("item_list") private List itemList = new ArrayList(); - - public String getOrderId() { - return orderId; - } - - public void setOrderId(String orderId) { - this.orderId = orderId; - } - - public String getPlatformOrderNo() { - return platformOrderNo; - } - - public void setPlatformOrderNo(String platformOrderNo) { - this.platformOrderNo = platformOrderNo; - } - - public List getPlatformOrderNames() { - return platformOrderNames; - } - - public void setPlatformOrderNames(List platformOrderNames) { - this.platformOrderNames = platformOrderNames; - } - - public Integer getPlatformCode() { - return platformCode; - } - - public void setPlatformCode(Integer platformCode) { - this.platformCode = platformCode; - } - - public String getStoreId() { - return storeId; - } - - public void setStoreId(String storeId) { - this.storeId = storeId; - } - - public String getOrderStatus() { - return orderStatus; - } - - public void setOrderStatus(String orderStatus) { - this.orderStatus = orderStatus; - } - - public String getBuyerName() { - return buyerName; - } - - public void setBuyerName(String buyerName) { - this.buyerName = buyerName; - } - - public String getCountryCode() { - return countryCode; - } - - public void setCountryCode(String countryCode) { - this.countryCode = countryCode; - } - - public String getCurrencyCode() { - return currencyCode; - } - - public void setCurrencyCode(String currencyCode) { - this.currencyCode = currencyCode; - } - - public String getOrderTotal() { - return orderTotal; - } - - public void setOrderTotal(String orderTotal) { - this.orderTotal = orderTotal; - } - - public String getPurchaseTimeLocale() { - return purchaseTimeLocale; - } - - public void setPurchaseTimeLocale(String purchaseTimeLocale) { - this.purchaseTimeLocale = purchaseTimeLocale; - } - - public Long getPurchaseTime() { - return purchaseTime; - } - - public void setPurchaseTime(Long purchaseTime) { - this.purchaseTime = purchaseTime; - } - - public Long getUpdateTime() { - return updateTime; - } - - public void setUpdateTime(Long updateTime) { - this.updateTime = updateTime; - } - - public String getUpdateTimeLocale() { - return updateTimeLocale; - } - - public void setUpdateTimeLocale(String updateTimeLocale) { - this.updateTimeLocale = updateTimeLocale; - } - - public List getItemList() { - return itemList; - } - - public void setItemList(List itemList) { - this.itemList = itemList; - } } diff --git a/lingxing/src/main/java/common/ecommerce/lingxing/dto/LingxingOrderItemDto.java b/lingxing/src/main/java/common/ecommerce/lingxing/dto/LingxingOrderItemDto.java index 3a0e485..6f3f87b 100644 --- a/lingxing/src/main/java/common/ecommerce/lingxing/dto/LingxingOrderItemDto.java +++ b/lingxing/src/main/java/common/ecommerce/lingxing/dto/LingxingOrderItemDto.java @@ -2,8 +2,16 @@ package common.ecommerce.lingxing.dto; import com.fasterxml.jackson.annotation.JsonIgnoreProperties; import com.fasterxml.jackson.annotation.JsonProperty; - -/** 领星订单明细行。字段名待官方文档核对。 */ +import lombok.Getter; +import lombok.Setter; + +/** + * 领星订单明细行。字段名待官方文档核对。 + * + *

纯数据容器,使用 Lombok 生成访问器。

+ */ +@Getter +@Setter @JsonIgnoreProperties(ignoreUnknown = true) public class LingxingOrderItemDto { @@ -29,60 +37,4 @@ public class LingxingOrderItemDto { @JsonProperty("discount") private String discount; - - public String getOrderItemId() { - return orderItemId; - } - - public void setOrderItemId(String orderItemId) { - this.orderItemId = orderItemId; - } - - public String getSku() { - return sku; - } - - public void setSku(String sku) { - this.sku = sku; - } - - public String getPlatformSku() { - return platformSku; - } - - public void setPlatformSku(String platformSku) { - this.platformSku = platformSku; - } - - public Integer getQuantity() { - return quantity; - } - - public void setQuantity(Integer quantity) { - this.quantity = quantity; - } - - public String getItemPrice() { - return itemPrice; - } - - public void setItemPrice(String itemPrice) { - this.itemPrice = itemPrice; - } - - public String getTax() { - return tax; - } - - public void setTax(String tax) { - this.tax = tax; - } - - public String getDiscount() { - return discount; - } - - public void setDiscount(String discount) { - this.discount = discount; - } } diff --git a/pom.xml b/pom.xml index 12db89f..f27a175 100644 --- a/pom.xml +++ b/pom.xml @@ -22,6 +22,7 @@ 2.13.5 1.7.36 5.8.2 + 1.18.30 @@ -65,6 +66,12 @@ ${slf4j.version}
+ org.projectlombok + lombok + ${lombok.version} + provided + + org.junit.jupiter junit-jupiter ${junit.version}